[webkit-reviews] review granted: [Bug 235436] [GTK] REGRESSION: Touch scrolling is broken : [Attachment 449804] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 25 09:42:54 PST 2022

Chris Lord <clord at igalia.com> has granted Alexander Mikhaylenko
<alexm at gnome.org>'s request for review:
Bug 235436: [GTK] REGRESSION: Touch scrolling is broken

Attachment 449804: Patch


--- Comment #13 from Chris Lord <clord at igalia.com> ---
Comment on attachment 449804
  --> https://bugs.webkit.org/attachment.cgi?id=449804

View in context: https://bugs.webkit.org/attachment.cgi?id=449804&action=review

LGTM. Wondering about that sign, but I assume you've tested it :)

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:2013
> +	   webkitWebViewBaseSynthesizeWheelEvent(webViewBase, event,
-velocityX, -velocityY, x, y, WheelEventPhase::NoPhase, WheelEventPhase::Began,

Is flipping the sign of velocityY here intentional?

More information about the webkit-reviews mailing list