[webkit-reviews] review granted: [Bug 235535] Network Cache: do not use disk cache for Fetch media loads : [Attachment 449846] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 24 23:00:28 PST 2022
Darin Adler <darin at apple.com> has granted Olivier Blin
<olivier.blin at softathome.com>'s request for review:
Bug 235535: Network Cache: do not use disk cache for Fetch media loads
https://bugs.webkit.org/show_bug.cgi?id=235535
Attachment 449846: Patch
https://bugs.webkit.org/attachment.cgi?id=449846&action=review
--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 449846
--> https://bugs.webkit.org/attachment.cgi?id=449846
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=449846&action=review
Looks good
> Source/WebKit/ChangeLog:23
> + No new tests (OOPS!).
Can’t land a patch that still has this in it. Need to remove this line, and
replace it with an explanation of why we are landing this patch without any
tests. Might want to look back at the original XHR change to see how they wrote
the test.
More information about the webkit-reviews
mailing list