[webkit-reviews] review granted: [Bug 235347] [libpas] it should be possible to decommit unused parts of a thread_local_cache (update to 434465bfb8e0c285d6763cf6aa0e04982199f824) : [Attachment 449637] updated patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 235347: [libpas] it should be possible to decommit unused parts of a
thread_local_cache (update to 434465bfb8e0c285d6763cf6aa0e04982199f824)
https://bugs.webkit.org/show_bug.cgi?id=235347

Attachment 449637: updated patch

https://bugs.webkit.org/attachment.cgi?id=449637&action=review




--- Comment #4 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 449637
  --> https://bugs.webkit.org/attachment.cgi?id=449637
updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449637&action=review

r=me

> Source/bmalloc/libpas/src/libpas/pas_committed_pages_vector.c:1
> +/*

Can you add it to CMakeLists.txt too?

> Source/bmalloc/libpas/src/libpas/pas_committed_pages_vector.h:1
> +/*

Ditto.

>
Source/bmalloc/libpas/src/libpas/pas_compact_thread_local_cache_layout_node.h:1
> +/*

Ditto.

> Source/bmalloc/libpas/src/libpas/pas_decommit_exclusion_range.h:1
> +/*

Ditto.

> Source/bmalloc/libpas/src/libpas/pas_large_virtual_range.h:1
> +/*

Ditto.

> Source/bmalloc/libpas/src/libpas/pas_large_virtual_range_min_heap.h:1
> +/*

Ditto.

> Source/bmalloc/libpas/src/libpas/pas_mmap_capability.h:1
> +/*

Ditto.

> Source/bmalloc/libpas/src/libpas/pas_thread_local_cache.c:981
> +    if ( verbose)

Remove this space.

> Source/bmalloc/libpas/src/libpas/pas_thread_local_cache_layout_entry.h:1
> +/*

Ditto.