[webkit-reviews] review granted: [Bug 235538] Web Inspector: Network: move filtering checkboxes into a single gear-with-contextmenu to save space : [Attachment 449852] [fast-cq] Patch

[bugzilla-daemon at webkit.org]

Patrick Angle <pangle at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 235538: Web Inspector: Network: move filtering checkboxes into a single
gear-with-contextmenu to save space
https://bugs.webkit.org/show_bug.cgi?id=235538

Attachment 449852: [fast-cq] Patch

https://bugs.webkit.org/attachment.cgi?id=449852&action=review




--- Comment #2 from Patrick Angle <pangle at apple.com> ---
Comment on attachment 449852
  --> https://bugs.webkit.org/attachment.cgi?id=449852
[fast-cq] Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449852&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:2281
> +	   contextMenu.appendCheckboxItem(WI.UIString("Preserve Log"), () => {

An aside, but could certainly be dealt with in this same bug: `Preserve Log` to
me doesn't clearly communicate what this setting does. When I think "log", I
think about the Console Tab and `console.log` et al.. Something like "Clear
requests on navigation" or "Clear request history on navigation" (subject to
further bike shedding) would better communicate the option IMO now that these
are in a dropdown menu and we have a bit more space.