[webkit-reviews] review granted: [Bug 235503] Pass the Document through bindings to KeyframeEffect::setKeyframes() : [Attachment 449790] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Antoine Quint <graouts at webkit.org>'s
request for review:
Bug 235503: Pass the Document through bindings to
KeyframeEffect::setKeyframes()
https://bugs.webkit.org/show_bug.cgi?id=235503

Attachment 449790: Patch

https://bugs.webkit.org/attachment.cgi?id=449790&action=review




--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 449790
  --> https://bugs.webkit.org/attachment.cgi?id=449790
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449790&action=review

> Source/WebCore/animation/KeyframeEffect.cpp:210
> -	   auto* scriptExecutionContext =
jsCast<JSDOMGlobalObject*>(&lexicalGlobalObject)->scriptExecutionContext();
> -	   if (is<Document>(scriptExecutionContext)) {
> -	       if
(downcast<Document>(*scriptExecutionContext).settings().webAnimationsCompositeO
perationsEnabled())
> -		   baseProperties.composite = baseKeyframe.composite;
> -	   }
> +	   if (document.settings().webAnimationsCompositeOperationsEnabled())
> +	       baseProperties.composite = baseKeyframe.composite;

This seems right, but in future, you can actually get settings directly from
the ScriptExecutionContext via the settingsValues() accessor.