[webkit-reviews] review denied: [Bug 235436] [GTK] REGRESSION: Touch scrolling is broken : [Attachment 449789] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 24 02:12:52 PST 2022

Chris Lord <clord at igalia.com> has denied Alexander Mikhaylenko
<alexm at gnome.org>'s request for review:
Bug 235436: [GTK] REGRESSION: Touch scrolling is broken

Attachment 449789: Patch


--- Comment #5 from Chris Lord <clord at igalia.com> ---
Comment on attachment 449789
  --> https://bugs.webkit.org/attachment.cgi?id=449789

View in context: https://bugs.webkit.org/attachment.cgi?id=449789&action=review

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:2014
> +	   webkitWebViewBaseSynthesizeWheelEvent(webViewBase, event, 0, 0, x,
y, WheelEventPhase::Ended, WheelEventPhase::NoPhase);

Great that this is so simple - I don't know if this will affect test results
anywhere, but EWS ought to tell us soon I suppose. Looks fine to me though.

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:3020
> +	   delta, wheelTicks, toWebKitWheelEventPhase(phase),
toWebKitWheelEventPhase(momentumPhase), true));

This will definitely cause many tests to fail - precise deltas will need to be
conditionally enabled for wheel events synthesised by touch events.

More information about the webkit-reviews mailing list