[webkit-reviews] review granted: [Bug 235461] Improve FourCC to use more inlining, fix incorrect mix of WEBCORE_EXPORT on entire class with inline functions : [Attachment 449758] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 23 16:08:39 PST 2022


Sam Weinig <sam at webkit.org> has granted Darin Adler <darin at apple.com>'s request
for review:
Bug 235461: Improve FourCC to use more inlining, fix incorrect mix of
WEBCORE_EXPORT on entire class with inline functions
https://bugs.webkit.org/show_bug.cgi?id=235461

Attachment 449758: Patch

https://bugs.webkit.org/attachment.cgi?id=449758&action=review




--- Comment #7 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 449758
  --> https://bugs.webkit.org/attachment.cgi?id=449758
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449758&action=review

> Source/WebCore/platform/graphics/FourCC.cpp:36
> +	   static_cast<char>(string[0]),

Are there any other rules worth asserting here? For instance, can a character
be '\0'?


More information about the webkit-reviews mailing list