[webkit-reviews] review granted: [Bug 235394] m_lastStyleChangeEventStyle null ptr deref for accelerated CSS Animation with no duration and an implicit keyframe : [Attachment 449754] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 23 10:35:55 PST 2022


Antti Koivisto <koivisto at iki.fi> has granted Antoine Quint
<graouts at webkit.org>'s request for review:
Bug 235394: m_lastStyleChangeEventStyle null ptr deref for accelerated CSS
Animation with no duration and an implicit keyframe
https://bugs.webkit.org/show_bug.cgi?id=235394

Attachment 449754: Patch

https://bugs.webkit.org/attachment.cgi?id=449754&action=review




--- Comment #6 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 449754
  --> https://bugs.webkit.org/attachment.cgi?id=449754
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449754&action=review

> Source/WebCore/animation/KeyframeEffect.cpp:1866
> +	   auto underlyingStyle = [&]() -> std::unique_ptr<RenderStyle> {

Probably don’t need explicit return type.


More information about the webkit-reviews mailing list