[webkit-reviews] review granted: [Bug 235467] [GPU Process] Add the class 'SourceImage' to represent variants of image : [Attachment 449722] Patch

[bugzilla-daemon at webkit.org]

Cameron McCormack (:heycam) <heycam at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 235467: [GPU Process] Add the class 'SourceImage' to represent variants of
image
https://bugs.webkit.org/show_bug.cgi?id=235467

Attachment 449722: Patch

https://bugs.webkit.org/attachment.cgi?id=449722&action=review




--- Comment #4 from Cameron McCormack (:heycam) <heycam at apple.com> ---
Comment on attachment 449722
  --> https://bugs.webkit.org/attachment.cgi?id=449722
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449722&action=review

> Source/WebCore/ChangeLog:8
> +	   Before the existence of GPUProces we used to make some drawing on an


"GPUProcess"

s/make some drawing/do some drawing/

> Source/WebCore/ChangeLog:10
> +	   NativeImage. With GPUProces, this will require bouncing the
NativeImage 

"GPUProcess"

> Source/WebCore/ChangeLog:11
> +	   between WebPorcess and GPUProcess at least two times. To make this
scenario 

"WebProcess"

> Source/WebCore/ChangeLog:12
> +	   efficient, a new class called SourceImage' will be introduced. The
purpose

Stray (or missing) apostrophe.

> Source/WebCore/platform/graphics/SourceImage.cpp:74
> +    auto imageBuffer = ImageBuffer::create(nativeImage->size(),
RenderingMode::Unaccelerated, 1, DestinationColorSpace::SRGB(),
PixelFormat::BGRA8);

If canvas patterns will use this class, then they'll need a way to specify the
color space when creating the ImageBuffer, so that we don't always convert to
sRGB.