[webkit-reviews] review granted: [Bug 235459] WebKit fails to build - error: 'webrtc/rtc_base/network.h' file not found : [Attachment 449705] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 21 16:45:01 PST 2022

Mark Lam <mark.lam at apple.com> has granted Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 235459: WebKit fails to build - error: 'webrtc/rtc_base/network.h' file not

Attachment 449705: Patch


--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 449705
  --> https://bugs.webkit.org/attachment.cgi?id=449705

View in context: https://bugs.webkit.org/attachment.cgi?id=449705&action=review

I'm not super familiar with the plumbing of all the settings variables, but
this patch LGTM.

> Source/ThirdParty/libwebrtc/Scripts/create-symlink-to-altroot.sh:27
sed -E -e "s/\/[a-zA-Z0-9_]+/..\//g" -e "s/\/$//")

Why is this "s/\/$//" needed?

> Source/ThirdParty/libwebrtc/Scripts/create-symlink-to-altroot.sh:28
> +   

nit: call this SYMLINK_TARGET instead?

> Source/ThirdParty/libwebrtc/Scripts/create-symlink-to-altroot.sh:52
> +	   if [[ ! -d ${SYSTEM_PUBLIC_HEADER_PREFIX} ]]; then
> +	       mkdir -p ${SYSTEM_PUBLIC_HEADER_PREFIX}
> +	   fi

Can't you do this just once outside of the for loop?  The only difference is
that moving this out would create this directory even if HEADER_FOLDER_LIST is
empty.	But we know it'll never be empty, right?

> Source/ThirdParty/libwebrtc/Scripts/create-symlink-to-altroot.sh:64
> +	   if [[ ! -d ${SYSTEM_PUBLIC_LIBRARY_PREFIX} ]]; then
> +	       mkdir -p ${SYSTEM_PUBLIC_LIBRARY_PREFIX}
> +	   fi

Ditto.	Do this outside the for loop?

More information about the webkit-reviews mailing list