[webkit-reviews] review granted: [Bug 235449] REGRESSION(r282320): [Cocoa] User-installed fonts don't work in the GPU Process (in WKWebView) : [Attachment 449689] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 235449: REGRESSION(r282320): [Cocoa] User-installed fonts don't work in the
GPU Process (in WKWebView)
https://bugs.webkit.org/show_bug.cgi?id=235449

Attachment 449689: Patch

https://bugs.webkit.org/attachment.cgi?id=449689&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 449689
  --> https://bugs.webkit.org/attachment.cgi?id=449689
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449689&action=review

> Source/WebCore/PAL/pal/spi/cf/CoreTextSPI.h:100
> +typedef CF_OPTIONS(uint32_t, CTFontDescriptorOptions) {
> +    kCTFontDescriptorOptionThisIsNotARealOption = 0xFFFFFFFF
> +};

Or we could just typedef it to uint32_t.

> Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:468
>	   encoder << String(string);

Seems a shame we have to convert CFString to String just to encode it on the
wire. A repeated pattern.