[webkit-reviews] review granted: [Bug 203148] texImage2d fails to set same video frame to multiple textures : [Attachment 449664] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 21 11:17:57 PST 2022

Darin Adler <darin at apple.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 203148: texImage2d fails to set same video frame to multiple textures

Attachment 449664: Patch


--- Comment #9 from Darin Adler <darin at apple.com> ---
Comment on attachment 449664
  --> https://bugs.webkit.org/attachment.cgi?id=449664

View in context: https://bugs.webkit.org/attachment.cgi?id=449664&action=review

> Source/WebCore/platform/graphics/cv/GraphicsContextGLCVCocoa.cpp:611
> +    if (it != m_knownContent.end()) {
> +	   if (it->value == content) {

Use && instead of nesting?

> Source/WebCore/platform/graphics/cv/GraphicsContextGLCVCocoa.h:71
> +	   // TODO: Switch back to UnsafePointer<IOSurfaceRef> once
UnsafePointer is safe to compare.

WebKit style uses FIXME for this. Means the same as TODO.

> Source/WebCore/platform/graphics/cv/GraphicsContextGLCVCocoa.h:81
> +	   bool operator==(const TextureContent& other) const;

Remove the name "other" please. I also think you might want to add a blank line
above this.

More information about the webkit-reviews mailing list