[webkit-reviews] review requested: [Bug 226088] [CMake] Cannot link libTestRunnerInjectedBundle.so in non unified build : [Attachment 449623] Updated patch with different cmake approach

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 20 16:36:14 PST 2022


Lauro Moura <lmoura at igalia.com> has asked  for review:
Bug 226088: [CMake] Cannot link libTestRunnerInjectedBundle.so in non unified
build
https://bugs.webkit.org/show_bug.cgi?id=226088

Attachment 449623: Updated patch with different cmake approach

https://bugs.webkit.org/attachment.cgi?id=449623&action=review




--- Comment #10 from Lauro Moura <lmoura at igalia.com> ---
Created attachment 449623

  --> https://bugs.webkit.org/attachment.cgi?id=449623&action=review

Updated patch with different cmake approach

Instead of pulling WebCore as WebCoreTestSupport dependency directly, make
WTR/WTRInjected bundle pull it instead. As the CMake-related code changed,
cleared the Reviewed-By field (will wait for green bubbles before rq'ing it).


More information about the webkit-reviews mailing list