[webkit-reviews] review granted: [Bug 235413] [macOS] Various tests hit debug assertions under `SearchBuffer::search` after system ICU changes : [Attachment 449598] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 20 11:43:12 PST 2022


Darin Adler <darin at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 235413: [macOS] Various tests hit debug assertions under
`SearchBuffer::search` after system ICU changes
https://bugs.webkit.org/show_bug.cgi?id=235413

Attachment 449598: Patch

https://bugs.webkit.org/attachment.cgi?id=449598&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 449598
  --> https://bugs.webkit.org/attachment.cgi?id=449598
Patch

I think it’s likely we have other places where we are checking against
U_ZERO_ERROR where we really mean U_SUCCESS.


More information about the webkit-reviews mailing list