[webkit-reviews] review granted: [Bug 235186] Inject Launch Services database before NSApplication is initialized : [Attachment 449593] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 235186: Inject Launch Services database before NSApplication is initialized
https://bugs.webkit.org/show_bug.cgi?id=235186

Attachment 449593: Patch

https://bugs.webkit.org/attachment.cgi?id=449593&action=review




--- Comment #25 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 449593
  --> https://bugs.webkit.org/attachment.cgi?id=449593
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449593&action=review

r=me

> Source/WebKit/UIProcess/Network/NetworkProcessProxy.h:274
> +    bool sendNetworkProcessXPCEndpointToProcess(AuxiliaryProcessProxy&);

Personally, I feel we could drop "NetworkProcess" from the name now that it is
located on the NetworkProcessProxy class. Your call.

> Source/WebKit/UIProcess/Network/NetworkProcessProxyCocoa.mm:61
> +	   if (GPUProcessProxy::singletonIfCreated())

if (auto gpuProcess = GPUProcessProxy::singletonIfCreated())

> Source/WebKit/UIProcess/Network/NetworkProcessProxyCocoa.mm:62
> +	      
m_networkProcess->sendNetworkProcessXPCEndpointToProcess(*GPUProcessProxy::sing
letonIfCreated());

*gpuProcess