[webkit-reviews] review granted: [Bug 231674] Support in-process testing of IPC messages : [Attachment 447716] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 231674: Support in-process testing of IPC messages
https://bugs.webkit.org/show_bug.cgi?id=231674

Attachment 447716: Patch

https://bugs.webkit.org/attachment.cgi?id=447716&action=review




--- Comment #14 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 447716
  --> https://bugs.webkit.org/attachment.cgi?id=447716
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447716&action=review

r=me

> Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:286
> +#if ENABLE(IPC_TESTING_API)

Seems like this could just be part of the protected region of lines 279-284?

> Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:374
> +#if ENABLE(IPC_TESTING_API)

Seems like this could be inside the IPC_TESTING_API macro area (lines 367-371)?

> Source/WebKit/Platform/IPC/Connection.cpp:1291
> +    if (!iterator->value.isValidKey(identifier))

Why don't we want to mark the connection as dispatching an invalid message
anymore?

> Source/WebKit/Platform/IPC/Decoder.h:51
> +    using BufferDeallocator = Function<void(const uint8_t*, size_t)>;

Much nicer!

> Source/WebKit/WebAuthnProcess/WebAuthnConnectionToWebProcess.h:87
> +

Nit: Extra blank line!