[webkit-reviews] review granted: [Bug 235392] [LFC][IFC] Implement TextUtil::directionForTextContent : [Attachment 449585] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 235392: [LFC][IFC] Implement TextUtil::directionForTextContent
https://bugs.webkit.org/show_bug.cgi?id=235392

Attachment 449585: Patch

https://bugs.webkit.org/attachment.cgi?id=449585&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 449585
  --> https://bugs.webkit.org/attachment.cgi?id=449585
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449585&action=review

> Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp:345
> +TextDirection TextUtil::directionForTextContent(StringView content)
>  {
> -    ASSERT_NOT_IMPLEMENTED_YET();
> -    return TextDirection::LTR;
> +    if (content.is8Bit())
> +	   return TextDirection::LTR;
> +    return ubidi_getBaseDirection(content.characters16(), content.length())
== UBIDI_RTL ? TextDirection::RTL : TextDirection::LTR;
>  }

Nice