[webkit-reviews] review granted: [Bug 235403] [LFC][IFC] LineBuilder::layoutInlineContent should take PreviousLine : [Attachment 449576] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 235403: [LFC][IFC] LineBuilder::layoutInlineContent should take
PreviousLine
https://bugs.webkit.org/show_bug.cgi?id=235403

Attachment 449576: Patch

https://bugs.webkit.org/attachment.cgi?id=449576&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 449576
  --> https://bugs.webkit.org/attachment.cgi?id=449576
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449576&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:308
> +LineBuilder::LineContent LineBuilder::layoutInlineContent(const
InlineItemRange& needsLayoutRange, const InlineRect& lineLogicalRect,
std::optional<PreviousLine> previousLine)

maybe the previousLine could be a const&? It is smallish but not tiny.