[webkit-reviews] review granted: [Bug 235236] Make LocalStorage prewarming async : [Attachment 449449] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 20 08:21:35 PST 2022

Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 235236: Make LocalStorage prewarming async

Attachment 449449: Patch


--- Comment #15 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 449449
  --> https://bugs.webkit.org/attachment.cgi?id=449449

View in context: https://bugs.webkit.org/attachment.cgi?id=449449&action=review

r=me with nit. Should probably monitor PLT bots after this lands given that
this changes a PLT optimization.

> Source/WebKit/NetworkProcess/storage/StorageAreaBase.cpp:52
> +    m_listeners.set(connection, identifier);

Why set() and not add()? add() is more efficient and based on your assertions
above, it seems add() would suffice.

More information about the webkit-reviews mailing list