[webkit-reviews] review granted: [Bug 235385] [XCBuild] Build via the workspace with USE_WORKSPACE=YES : [Attachment 449529] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 19 16:47:46 PST 2022

Alexey Proskuryakov <ap at webkit.org> has granted Elliott Williams
<emw at apple.com>'s request for review:
Bug 235385: [XCBuild] Build via the workspace with USE_WORKSPACE=YES

Attachment 449529: Patch


--- Comment #5 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 449529
  --> https://bugs.webkit.org/attachment.cgi?id=449529

View in context: https://bugs.webkit.org/attachment.cgi?id=449529&action=review

> Makefile.shared:153
> +	@true
> +else

I don't understand why this is needed. `make installsrc` is only invoked in
very specific circumstances, and when it is, it's really necessary. So it's not
clear to me how it would be invoked from the root makefile with workspace.

More information about the webkit-reviews mailing list