[webkit-reviews] review granted: [Bug 235385] [XCBuild] Build via the workspace with USE_WORKSPACE=YES : [Attachment 449529] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Elliott Williams
<emw at apple.com>'s request for review:
Bug 235385: [XCBuild] Build via the workspace with USE_WORKSPACE=YES
https://bugs.webkit.org/show_bug.cgi?id=235385

Attachment 449529: Patch

https://bugs.webkit.org/attachment.cgi?id=449529&action=review




--- Comment #5 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 449529
  --> https://bugs.webkit.org/attachment.cgi?id=449529
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449529&action=review

> Makefile.shared:153
> +ifeq ($(SKIP_INSTALLSRC),YES)
> +	@true
> +else

I don't understand why this is needed. `make installsrc` is only invoked in
very specific circumstances, and when it is, it's really necessary. So it's not
clear to me how it would be invoked from the root makefile with workspace.