[webkit-reviews] review requested: [Bug 235382] [JSC] move function wrapping logic to a new Function type : [Attachment 449517] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 19 14:07:48 PST 2022

Caitlin Potter (:caitp) <caitp at igalia.com> has asked  for review:
Bug 235382: [JSC] move function wrapping logic to a new Function type

Attachment 449517: Patch


--- Comment #1 from Caitlin Potter (:caitp) <caitp at igalia.com> ---
Created attachment 449517

  --> https://bugs.webkit.org/attachment.cgi?id=449517&action=review


This is just a starter patch, it has some things which could be better --- For
the thunk, the rethrowing logic does not actually work, and I need some
clarification on getting that set up. It might be good for allocation to occur
inline, rather than in C operations. As noted in the changelog, at this time
thhtere isn't anything added to DFG/FTL, but potentially there are
opportunities there. I'm hoping I can get some feedback on the initial version
and see if we actually prefer this to the JS builtin we've already got.

More information about the webkit-reviews mailing list