[webkit-reviews] review granted: [Bug 235379] Turn EUnicodeBidi into an enum class : [Attachment 449512] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 19 13:45:06 PST 2022


Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 235379: Turn EUnicodeBidi into an enum class
https://bugs.webkit.org/show_bug.cgi?id=235379

Attachment 449512: Patch

https://bugs.webkit.org/attachment.cgi?id=449512&action=review




--- Comment #5 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 449512
  --> https://bugs.webkit.org/attachment.cgi?id=449512
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449512&action=review

>> Source/WebCore/platform/text/UnicodeBidi.h:31
>> +enum class EUnicodeBidi : uint8_t {
> 
> Can we drop the E prefix?

We should.


More information about the webkit-reviews mailing list