[webkit-reviews] review denied: [Bug 235372] [bmalloc][32-bits] Build error in libpas after r285853 : [Attachment 449507] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 19 13:22:57 PST 2022
Yusuke Suzuki <ysuzuki at apple.com> has denied Pablo Saavedra
<psaavedra at igalia.com>'s request for review:
Bug 235372: [bmalloc][32-bits] Build error in libpas after r285853
https://bugs.webkit.org/show_bug.cgi?id=235372
Attachment 449507: patch
https://bugs.webkit.org/attachment.cgi?id=449507&action=review
--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 449507
--> https://bugs.webkit.org/attachment.cgi?id=449507
patch
libpas does not support 32bit environment. So the right fix is ensuring that
all built libpas C files are guarded by LIBPAS_ENABLED so that we do not build
this file.
Can you paste which file is including pas_utils.h?
More information about the webkit-reviews
mailing list