[webkit-reviews] review granted: [Bug 235194] <dialog> with transformed ancestor asserts under RenderGeometryMap : [Attachment 449499] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 19 11:49:32 PST 2022

Antti Koivisto <koivisto at iki.fi> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 235194: <dialog> with transformed ancestor asserts under RenderGeometryMap

Attachment 449499: Patch


--- Comment #7 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 449499
  --> https://bugs.webkit.org/attachment.cgi?id=449499

View in context: https://bugs.webkit.org/attachment.cgi?id=449499&action=review

> Source/WebCore/rendering/RenderElement.cpp:637
> +static RenderLayer* findNextLayer(const RenderElement& currRenderer,
RenderLayer& parentLayer, const RenderObject* siblingToTraverseFrom, bool
checkParent = true)

I know this is just function that moves but it would nice to make it better. I
suspect what it does could be expressed cleanly (by making it iterative and
separation layer testing from traversal) but currently it is pretty

currRenderer is not current WebKit style

It is not super clear what "next layer" here means. Next in depth-first order?
siblingToTraverseFrom is really weird too.

More information about the webkit-reviews mailing list