[webkit-reviews] review granted: [Bug 235194] <dialog> with transformed ancestor asserts under RenderGeometryMap : [Attachment 449499] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 235194: <dialog> with transformed ancestor asserts under RenderGeometryMap
https://bugs.webkit.org/show_bug.cgi?id=235194

Attachment 449499: Patch

https://bugs.webkit.org/attachment.cgi?id=449499&action=review




--- Comment #7 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 449499
  --> https://bugs.webkit.org/attachment.cgi?id=449499
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449499&action=review

> Source/WebCore/rendering/RenderElement.cpp:637
> +static RenderLayer* findNextLayer(const RenderElement& currRenderer,
RenderLayer& parentLayer, const RenderObject* siblingToTraverseFrom, bool
checkParent = true)

I know this is just function that moves but it would nice to make it better. I
suspect what it does could be expressed cleanly (by making it iterative and
separation layer testing from traversal) but currently it is pretty
incomprehensible.

currRenderer is not current WebKit style

It is not super clear what "next layer" here means. Next in depth-first order?
siblingToTraverseFrom is really weird too.