[webkit-reviews] review granted: [Bug 234648] Web Inspector: blackboxed call frames should be grouped everywhere : [Attachment 449279] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 19 10:53:06 PST 2022


Patrick Angle <pangle at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 234648: Web Inspector: blackboxed call frames should be grouped everywhere
https://bugs.webkit.org/show_bug.cgi?id=234648

Attachment 449279: Patch

https://bugs.webkit.org/attachment.cgi?id=449279&action=review




--- Comment #3 from Patrick Angle <pangle at apple.com> ---
Comment on attachment 449279
  --> https://bugs.webkit.org/attachment.cgi?id=449279
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449279&action=review

r=me

> Source/WebInspectorUI/UserInterface/Models/StackTrace.js:163
> +		   firstNonNativeNonAnonymousCallFrame ??= frame;

Nice catch. It's a bit concerning that we don't seem to test this anywhere,
though.


More information about the webkit-reviews mailing list