[webkit-reviews] review granted: [Bug 234986] WebsiteDataStore.cpp uses switch statements for WebKit::ProcessAccessType enum that fall through ASSERT_NOT_REACHED() : [Attachment 449490] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 234986: WebsiteDataStore.cpp uses switch statements for
WebKit::ProcessAccessType enum that fall through ASSERT_NOT_REACHED()
https://bugs.webkit.org/show_bug.cgi?id=234986

Attachment 449490: Patch

https://bugs.webkit.org/attachment.cgi?id=449490&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 449490
  --> https://bugs.webkit.org/attachment.cgi?id=449490
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449490&action=review

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:550
>      UNUSED_PARAM(isNonPersistentStore);

I suggest we omit the argument name instead of using UNUSED_PARAM. Could even
put it in comments. The reason I always try to avoid UNUSED_PARAM is that it
doesn’t even prevent the code from using the parameter.

But also, why are we even passing this boolean argument to this function? Let’s
just omit it.