[webkit-reviews] review granted: [Bug 235363] [Model] Mouse interaction for <model> is flipped in the y-axis : [Attachment 449478] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 19 08:49:19 PST 2022


Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at webkit.org>'s
request for review:
Bug 235363: [Model] Mouse interaction for <model> is flipped in the y-axis
https://bugs.webkit.org/show_bug.cgi?id=235363

Attachment 449478: Patch

https://bugs.webkit.org/attachment.cgi?id=449478&action=review




--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 449478
  --> https://bugs.webkit.org/attachment.cgi?id=449478
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449478&action=review

> Source/WebKit/ChangeLog:9
> +	   The mouse coordinates come from the Web page but are consumed by
ARQL, so we need
> +	   to flip coordinates in the y-axis.

Don't we have to flip by doing (height - location) rather than just
(-location)?


More information about the webkit-reviews mailing list