[webkit-reviews] review granted: [Bug 224471] Release assert in Document::updateLayout() via HTMLTextAreaElement::childrenChanged : [Attachment 444528] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 224471: Release assert in Document::updateLayout() via
HTMLTextAreaElement::childrenChanged
https://bugs.webkit.org/show_bug.cgi?id=224471

Attachment 444528: Patch

https://bugs.webkit.org/attachment.cgi?id=444528&action=review




--- Comment #47 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 444528
  --> https://bugs.webkit.org/attachment.cgi?id=444528
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444528&action=review

> Source/WebCore/editing/FrameSelection.cpp:2515
> +    m_document->updateLayoutIgnorePendingStylesheets();

Why do we need this separate layout update in addition to calling
updateSelectionAppearanceNow below?
Please explain it in the change log or even add a comment here.

> Source/WebCore/html/HTMLFormControlElement.cpp:496
>      focus();
> +    Ref { document()
}->selection().updateAppearanceIfRevealingSelectionIsNeeded();

Why is calling focus() not enough here? Please explain it in the change log
and/or add a comment here.