[webkit-reviews] review canceled: [Bug 235336] Fix -Wreturn-type and -Wunused-parameter warnings, January 2022 edition : [Attachment 449433] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has canceled Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 235336: Fix -Wreturn-type and -Wunused-parameter warnings, January 2022
edition
https://bugs.webkit.org/show_bug.cgi?id=235336

Attachment 449433: Patch

https://bugs.webkit.org/attachment.cgi?id=449433&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 449433
  --> https://bugs.webkit.org/attachment.cgi?id=449433
Patch

Can’t use RELEASE_ASSERT_NOT_REACHED in constexpr functions.
RELEASE_ASSERT_UNDER_CONSTEXPR_CONTEXT does work, although we don’t have a
straight "NOT_REACHED" version, so we could do the inelegant
RELEASE_ASSERT_UNDER_CONSTEXPR_CONTEXT(false)