[webkit-reviews] review granted: [Bug 235334] Speedometer should be locally runnable on Windows : [Attachment 449427] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 18 14:47:42 PST 2022


Don Olmstead <don.olmstead at sony.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 235334: Speedometer should be locally runnable on Windows
https://bugs.webkit.org/show_bug.cgi?id=235334

Attachment 449427: Patch

https://bugs.webkit.org/attachment.cgi?id=449427&action=review




--- Comment #2 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 449427
  --> https://bugs.webkit.org/attachment.cgi?id=449427
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449427&action=review

r=me

> PerformanceTests/.gitattributes:8
>
+Speedometer/resources/todomvc/architecture-examples/emberjs/dist/assets/todomv
c-5d3e8eb3d5b3740a33185edcb11eeb57.js -crlf
>
+Speedometer/resources/todomvc/architecture-examples/emberjs/dist/assets/vendor
-820919567eb7bd4d9fac358a90a5aac4.js -crlf

My only concern is that the hash would be updated and then this issue would
crop up again but that's minor.


More information about the webkit-reviews mailing list