[webkit-reviews] review granted: [Bug 235319] CSP: Fix returned WebAssembly error type when blocked : [Attachment 449402] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Patrick Griffis
<pgriffis at igalia.com>'s request for review:
Bug 235319: CSP: Fix returned WebAssembly error type when blocked
https://bugs.webkit.org/show_bug.cgi?id=235319

Attachment 449402: Patch

https://bugs.webkit.org/attachment.cgi?id=449402&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 449402
  --> https://bugs.webkit.org/attachment.cgi?id=449402
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449402&action=review

Looks like a good change, but a lot of tests are failing on mac-wk1, please
don’t land without investigating that.

Also, this should be two patches, not as single patch.

> Source/JavaScriptCore/wasm/js/JSWebAssemblyInstance.cpp:176
> +	   return exception(createJSWebAssemblyCompileError(globalObject, vm,
globalObject->webAssemblyDisabledErrorMessage()));

This should be two separate patches.

First, import the tests.

Then, add the fix and update the test results to show the newly-passing tests.

Combining the two isn’t great.