[webkit-reviews] review granted: [Bug 234343] [JSC] Further unification in run-jsc-stress-tests : [Attachment 447225] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has granted Angelos Oikonomopoulos
<angelos at igalia.com>'s request for review:
Bug 234343: [JSC] Further unification in run-jsc-stress-tests
https://bugs.webkit.org/show_bug.cgi?id=234343

Attachment 447225: Patch

https://bugs.webkit.org/attachment.cgi?id=447225&action=review




--- Comment #4 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 447225
  --> https://bugs.webkit.org/attachment.cgi?id=447225
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447225&action=review

> Tools/ChangeLog:12
> +	   When defaultNoNoLLIntRun was added in
https://github.com/WebKit/WebKit/commit/5bdfa5675fffa3939e7a66cb6947b607dc0040e
d,

Could we use identifiers or revisions here? This one would be
https://commits.webkit.org/176404@main (it's in the commit message). The
advantage of commits.webkit.org is that those links will redirect to GitHub
when SVN dies.