[webkit-reviews] review granted: [Bug 235303] [GTK] Implement native form validation bubbles for GTK4 : [Attachment 449362] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 18 00:25:35 PST 2022


Carlos Garcia Campos <cgarcia at igalia.com> has granted ChangSeok Oh
<changseok at webkit.org>'s request for review:
Bug 235303: [GTK] Implement native form validation bubbles for GTK4
https://bugs.webkit.org/show_bug.cgi?id=235303

Attachment 449362: Patch

https://bugs.webkit.org/attachment.cgi?id=449362&action=review




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 449362
  --> https://bugs.webkit.org/attachment.cgi?id=449362
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449362&action=review

> Source/WebCore/platform/gtk/ValidationBubbleGtk.cpp:68
> +#if USE(GTK4)
> +    gtk_label_set_wrap(GTK_LABEL(label), TRUE);
> +#else
>      gtk_label_set_line_wrap(GTK_LABEL(label), TRUE);
> +#endif

Include <WebCore/GtkVersioning.h> and just use gtk_label_set_line_wrap()
without ifdefs.


More information about the webkit-reviews mailing list