[webkit-reviews] review granted: [Bug 235295] AX Isolated Tree Mode: Re-compute AXPropertyName::IsEnabled when a node experiences AXDisabledStateChanged : [Attachment 449340] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 17 11:51:26 PST 2022


chris fleizach <cfleizach at apple.com> has granted Tyler Wilcock
<tyler_w at apple.com>'s request for review:
Bug 235295: AX Isolated Tree Mode: Re-compute AXPropertyName::IsEnabled when a
node experiences AXDisabledStateChanged
https://bugs.webkit.org/show_bug.cgi?id=235295

Attachment 449340: Patch

https://bugs.webkit.org/attachment.cgi?id=449340&action=review




--- Comment #3 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 449340
  --> https://bugs.webkit.org/attachment.cgi?id=449340
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449340&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:3385
> +	       tree->updateNodeProperty(*notification.first,
AXPropertyName::IsEnabled);

Why do we have two methods that seem to do the same work? Can we combine those?


More information about the webkit-reviews mailing list