[webkit-reviews] review granted: [Bug 234629] [GTK] Implement form validation with gtk3 widgets in the UI process : [Attachment 448086] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted ChangSeok Oh
<changseok at webkit.org>'s request for review:
Bug 234629: [GTK] Implement form validation with gtk3 widgets in the UI process
https://bugs.webkit.org/show_bug.cgi?id=234629

Attachment 448086: Patch

https://bugs.webkit.org/attachment.cgi?id=448086&action=review




--- Comment #8 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 448086
  --> https://bugs.webkit.org/attachment.cgi?id=448086
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448086&action=review

> Source/WebCore/platform/gtk/ValidationBubbleGtk.cpp:39
> +static const float horizontalMargin = 5;
> +static const float verticalMargin = 5;
> +static const float maxLabelWidthChars = 40;

I think it's ok to use the numbers directly for these, the same way you do for 
minimum font size or label lines.

> Source/WebCore/platform/gtk/ValidationBubbleGtk.cpp:94
> +    GtkWidget* webView =
gtk_popover_get_relative_to(GTK_POPOVER(m_popover));

We keep the web view as m_webView. So either don't keep it and get it always
with gtk_popover_get_relative_to(), or just use the member, no?

> Source/WebCore/platform/gtk/ValidationBubbleGtk.cpp:98
> +    if (m_shouldNotifyFocusEventsCallback)

This should not be optional.

> Source/WebCore/platform/gtk/ValidationBubbleGtk.cpp:106
> +    if (m_shouldNotifyFocusEventsCallback)

Ditto.