[webkit-reviews] review granted: [Bug 235284] REGRESSION (r249823): gl::Context::onProgramLink() leaks gl::Framebuffer object due early return when an error occurs in ANGLE_TRY() macro : [Attachment 449290] Patch v1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 235284: REGRESSION (r249823): gl::Context::onProgramLink() leaks
gl::Framebuffer object due early return when an error occurs in ANGLE_TRY()
macro
https://bugs.webkit.org/show_bug.cgi?id=235284

Attachment 449290: Patch v1

https://bugs.webkit.org/attachment.cgi?id=449290&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 449290
  --> https://bugs.webkit.org/attachment.cgi?id=449290
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=449290&action=review

> Source/ThirdParty/ANGLE/src/libANGLE/Context.cpp:9110
> +	   newDefaultFramebuffer =
std::unique_ptr<gl::Framebuffer>(drawSurface->createDefaultFramebuffer(this,
readSurface));

Can createDefaultFramebuffer be changed to return a std::unique_buffer?