[webkit-reviews] review granted: [Bug 235257] Two bopomofo tone marks are not moved to the correct place in vertical text with a particular bopomofo font : [Attachment 449287] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 235257: Two bopomofo tone marks are not moved to the correct place in
vertical text with a particular bopomofo font
https://bugs.webkit.org/show_bug.cgi?id=235257

Attachment 449287: Patch

https://bugs.webkit.org/attachment.cgi?id=449287&action=review




--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 449287
  --> https://bugs.webkit.org/attachment.cgi?id=449287
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449287&action=review

> Source/WebCore/ChangeLog:16
> +	   No new tests because this requires a custom font to test.

We need to do something about this; maybe make some more custom fonts for the
WebKit test suite. That situation is high risk for the project, I think. I’d
even like to see this kind of thing tested in WPT.