[webkit-reviews] review granted: [Bug 235261] [JSC] Fix misc issues in WebAssembly.Exception : [Attachment 449246] Patch

[bugzilla-daemon at webkit.org]

Alexey Shvayka <ashvayka at apple.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 235261: [JSC] Fix misc issues in WebAssembly.Exception
https://bugs.webkit.org/show_bug.cgi?id=235261

Attachment 449246: Patch

https://bugs.webkit.org/attachment.cgi?id=449246&action=review




--- Comment #6 from Alexey Shvayka <ashvayka at apple.com> ---
Comment on attachment 449246
  --> https://bugs.webkit.org/attachment.cgi?id=449246
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449246&action=review

r=me with ChangeLog nits.

> Source/JavaScriptCore/ChangeLog:10
> +

3. Throw TypeError instead of RangeError when implementing [EnforceRange]
extended attribute (step 6 of
https://webidl.spec.whatwg.org/#abstract-opdef-converttoint).

Also, a link to proposal spec would be nice:
https://github.com/WebAssembly/exception-handling/blob/main/proposals/exception
-handling/Exceptions.md#js-api.