[webkit-reviews] review granted: [Bug 235258] First step to fix hacked isReplaced: Rename isReplaced functions to isReplacedOrInlineBlock : [Attachment 449235] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 14 18:46:17 PST 2022
zalan <zalan at apple.com> has granted Darin Adler <darin at apple.com>'s request for
review:
Bug 235258: First step to fix hacked isReplaced: Rename isReplaced functions to
isReplacedOrInlineBlock
https://bugs.webkit.org/show_bug.cgi?id=235258
Attachment 449235: Patch
https://bugs.webkit.org/attachment.cgi?id=449235&action=review
--- Comment #3 from zalan <zalan at apple.com> ---
Comment on attachment 449235
--> https://bugs.webkit.org/attachment.cgi?id=449235
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=449235&action=review
> Source/WebCore/rendering/RenderReplica.cpp:48
> + // FIXME: Is the comment above obsolete? Can't find a check of
isReplacedOrInlineBlock guarding setHasTransform any more.
> + setReplacedOrInlineBlock(true);
Curious.
More information about the webkit-reviews
mailing list