[webkit-reviews] review granted: [Bug 235220] Loupe sometimes flips to the bottom of the page when dragging the end of a selection to the top of a page with seleciton flipping. : [Attachment 449212] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 235220: Loupe sometimes flips to the bottom of the page when dragging the
end of a selection to the top of a page with seleciton flipping.
https://bugs.webkit.org/show_bug.cgi?id=235220

Attachment 449212: Patch

https://bugs.webkit.org/attachment.cgi?id=449212&action=review




--- Comment #6 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 449212
  --> https://bugs.webkit.org/attachment.cgi?id=449212
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449212&action=review

> Also, is this function ever called with points that aren't from user input?
(and in which case constraining might be wrong?)

All codepaths that call into this function happen as a result of
`-changeSelectionWithTouchAt:withSelectionTouch:baseIsStart:withFlags:` in the
UI process, so I *suspect* this should be okay.

> Source/WebCore/ChangeLog:3
> +	   Loupe sometimes flips to the bottom of the page when dragging the
end of a selection to the top of a page with seleciton flipping.

Nit - "seleciton" is still misspelled here.

> Source/WebCore/ChangeLog:11
> +	   in the loupe being pushed to the bottom of the page (because the
seleciton was on the previous page

(Ditto)

> Source/WebKit/ChangeLog:3
> +	   Loupe sometimes flips to the bottom of the page when dragging the
end of a selection to the top of a page with seleciton flipping.

(Ditto)

> Source/WebKit/ChangeLog:11
> +	   in the loupe being pushed to the bottom of the page (because the
seleciton was on the previous page

(Ditto)