[webkit-reviews] review denied: [Bug 235232] [JSC] Fix Linux 64bit compilation : [Attachment 449204] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 14 12:42:03 PST 2022

Yusuke Suzuki <ysuzuki at apple.com> has denied Mikhail R. Gadelha
<mikhail at igalia.com>'s request for review:
Bug 235232: [JSC] Fix Linux 64bit compilation

Attachment 449204: Patch


--- Comment #6 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 449204
  --> https://bugs.webkit.org/attachment.cgi?id=449204

View in context: https://bugs.webkit.org/attachment.cgi?id=449204&action=review

> Source/bmalloc/ChangeLog:11
> +	   r287941 enabled jit-heap for all platforms and for some reason the  
> +	   preprocessor was not identifying PAS_USE_SPINLOCKS as defined. This
> +	   patch adds a #if defined(PAS_USE_SPINLOCKS) guard which fixes the
> +	   issue.

We should investigate why it is.

> Source/bmalloc/libpas/src/libpas/pas_config.h:100
> +#if defined(PAS_BMALLOC)
>  #define PAS_USE_SPINLOCKS		    1
>  #else
>  #define PAS_USE_SPINLOCKS		    0

Regardless of the condition, PAS_USE_SPINLOCKS is defined. So the following
change is incorrect.

> Source/bmalloc/libpas/src/libpas/pas_lock.h:54
> +#if defined(PAS_USE_SPINLOCKS)

This is not correct since PAS_USE_SPINLOCKS is always defined.

More information about the webkit-reviews mailing list