[webkit-reviews] review granted: [Bug 235179] Transmit network load metrics when service worker is using one of its network load to respond to FetchEvents : [Attachment 449086] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 235179: Transmit network load metrics when service worker is using one of
its network load to respond to FetchEvents
https://bugs.webkit.org/show_bug.cgi?id=235179

Attachment 449086: Patch

https://bugs.webkit.org/attachment.cgi?id=449086&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 449086
  --> https://bugs.webkit.org/attachment.cgi?id=449086
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449086&action=review

Assuming there is no performance problem with this additional IPC

> Source/WebCore/Modules/fetch/FetchResponse.h:123
> +    void setNetworkLoadMetrics(const NetworkLoadMetrics& networkLoadMetrics)
{ m_networkLoadMetrics = networkLoadMetrics; }

Would have named the argument just metrics.

> Source/WebCore/loader/WorkerThreadableLoader.cpp:243
> +void
WorkerThreadableLoader::MainThreadBridge::didFinishLoading(ResourceLoaderIdenti
fier identifier, const NetworkLoadMetrics& networkLoadMetrics)

Here too.