[webkit-reviews] review granted: [Bug 235226] Frequent GPU process jetsams due to RemoteRenderingBackendProxy not claiming ownership of SharedMemory buffers : [Attachment 449173] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 235226: Frequent GPU process jetsams due to RemoteRenderingBackendProxy not
claiming ownership of SharedMemory buffers
https://bugs.webkit.org/show_bug.cgi?id=235226

Attachment 449173: Patch

https://bugs.webkit.org/attachment.cgi?id=449173&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 449173
  --> https://bugs.webkit.org/attachment.cgi?id=449173
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449173&action=review

> Source/WebKit/Shared/ShareableBitmap.cpp:46
> +    m_handle.takeOwnershipOfMemory(ledger);

Should this assert that m_handle has an m_port already (otherwise the call is a
no-op)?