[webkit-reviews] review granted: [Bug 230617] gl.texImage2D upload of getUserMedia streams via <video> element fails : [Attachment 449160] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 230617: gl.texImage2D upload of getUserMedia streams via <video> element
fails
https://bugs.webkit.org/show_bug.cgi?id=230617

Attachment 449160: Patch

https://bugs.webkit.org/attachment.cgi?id=449160&action=review




--- Comment #15 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 449160
  --> https://bugs.webkit.org/attachment.cgi?id=449160
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449160&action=review

> Source/WebCore/ChangeLog:9
> +	   Fix MSE camera to WebGL texture uploads.

s/MSE/MediaStreamTrack/

> Source/WebCore/ChangeLog:12
> +	   Turns out MSE does not have these implemented, so currently fall
back

It should be easy to add such methods.
We have m_currentVideoSample we can grab for that using a lock.