[webkit-reviews] review granted: [Bug 235182] [GTK][WPE] Share code between NicosiaGCGLLayer+ANGLE and NicosiaImageBufferPipe : [Attachment 449058] Patch

[bugzilla-daemon at webkit.org]

Alejandro G. Castro <alex at igalia.com> has granted Chris Lord
<clord at igalia.com>'s request for review:
Bug 235182: [GTK][WPE] Share code between NicosiaGCGLLayer+ANGLE and
NicosiaImageBufferPipe
https://bugs.webkit.org/show_bug.cgi?id=235182

Attachment 449058: Patch

https://bugs.webkit.org/attachment.cgi?id=449058&action=review




--- Comment #3 from Alejandro G. Castro <alex at igalia.com> ---
Comment on attachment 449058
  --> https://bugs.webkit.org/attachment.cgi?id=449058
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449058&action=review

Great patch! Very helpful for the next refactorings.

> Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h:45
> -class GCGLANGLELayer;
> +class GCGLANGLEPipe;

Can we ifdef USE(ANGLE) like we do in the attribute definition?

> Source/WebCore/platform/graphics/nicosia/texmap/NicosiaGCGLANGLEPipe.h:51
> +class GCGLANGLEPipeSource;

Leftover?