[webkit-reviews] review granted: [Bug 235201] Link Wasm code on the same thread that JITs : [Attachment 449114] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 13 14:56:00 PST 2022


Yusuke Suzuki <ysuzuki at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 235201: Link Wasm code on the same thread that JITs
https://bugs.webkit.org/show_bug.cgi?id=235201

Attachment 449114: patch

https://bugs.webkit.org/attachment.cgi?id=449114&action=review




--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 449114
  --> https://bugs.webkit.org/attachment.cgi?id=449114
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449114&action=review

r=me

> Source/JavaScriptCore/wasm/WasmBBQPlan.cpp:201
> +	   auto result = m_embedderToWasmInternalFunctions.add(functionIndex,
std::pair<std::unique_ptr<LinkBuffer>, std::unique_ptr<InternalFunction>> {
WTFMove(linkBuffer), WTFMove(embedderToWasmInternalFunction) });

I think you can use `std::pair { ... }` instead of
`std::pair<std::unique_ptr<LinkBuffer>, std::unique_ptr<InternalFunction>>`.


More information about the webkit-reviews mailing list