[webkit-reviews] review granted: [Bug 235191] Expose way to encode CTAP commands with only hash of ClientDataJSON : [Attachment 449083] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted j_pascoe at apple.com
<j_pascoe at apple.com>'s request for review:
Bug 235191: Expose way to encode CTAP commands with only hash of ClientDataJSON
https://bugs.webkit.org/show_bug.cgi?id=235191

Attachment 449083: Patch

https://bugs.webkit.org/attachment.cgi?id=449083&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 449083
  --> https://bugs.webkit.org/attachment.cgi?id=449083
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449083&action=review

>> Source/WebKit/ChangeLog:9
>> +	    CTAP command encoding covered by existing tests. 
> 
> Do we have test cases for these new calls? Or will those tests be part of a
follow-up patch that uses these new commands?

I spoke with Pascoe about this, and he will ensure proper testing is available
in follow-up work.