[webkit-reviews] review granted: [Bug 235186] Inject Launch Services database before NSApplication is initialized : [Attachment 449067] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 235186: Inject Launch Services database before NSApplication is initialized
https://bugs.webkit.org/show_bug.cgi?id=235186

Attachment 449067: Patch

https://bugs.webkit.org/attachment.cgi?id=449067&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 449067
  --> https://bugs.webkit.org/attachment.cgi?id=449067
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449067&action=review

r=me

> Source/WebKit/WebProcess/cocoa/LaunchServicesDatabaseManager.mm:87
> +    auto startTime = WallTime::now();

Should probably be using MonotonicTime::now()

> Source/WebKit/WebProcess/cocoa/LaunchServicesDatabaseManager.mm:89
> +    auto elapsedTime = WallTime::now() - startTime;

ditto.

> Source/WebKit/WebProcess/cocoa/LaunchServicesDatabaseManager.mm:91
> +	   RELEASE_LOG(Loading, "Waiting for Launch Services database update
took %f seconds", elapsedTime.value());

Can we use RELEASE_LOG_ERROR so that it stands out in the logs? Any delay
during process initialization is very visible to the user and should be
avoided.