[webkit-reviews] review granted: [Bug 235161] [EWS] Load contributors from stand-alone class : [Attachment 449011] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 12 17:39:47 PST 2022

Aakash Jain <aakash_jain at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 235161: [EWS] Load contributors from stand-alone class

Attachment 449011: Patch


--- Comment #6 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 449011
  --> https://bugs.webkit.org/attachment.cgi?id=449011

View in context: https://bugs.webkit.org/attachment.cgi?id=449011&action=review

This re-organization seems fine, just need to be careful in subsequent patches
how exactly we use it, especially what we display to our users. Also left few

> Tools/CISupport/ews-build/steps.py:139
> +		       printable='{} <{}>'.format(name, emails[0].lower()),

let's skip this printable from this patch, and add it in subsequent patch when
we implement the exact use-case.

> Tools/CISupport/ews-build/steps.py:141
> +		       email=emails[0],

Do we need to store name here?

> Tools/CISupport/ews-build/steps.py:1016
> +    def __init__(self, *args, **kwargs):

Let's skip init and just have 'contributors = {}' as a class variable (as it
was before)

More information about the webkit-reviews mailing list