[webkit-reviews] review granted: [Bug 235160] PCM: Same-site triggering events should support ephemeral measurement : [Attachment 449006] [fast-cq] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 235160: PCM: Same-site triggering events should support ephemeral
measurement
https://bugs.webkit.org/show_bug.cgi?id=235160

Attachment 449006: [fast-cq] Patch

https://bugs.webkit.org/attachment.cgi?id=449006&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 449006
  --> https://bugs.webkit.org/attachment.cgi?id=449006
[fast-cq] Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449006&action=review

> Source/WebKit/NetworkProcess/NetworkSession.cpp:375
> +	   if
(ephemeralMeasurement.isNeitherSameSiteNorCrossSiteTriggeringEvent(redirectDoma
in, firstPartyForCookies, attributionTriggerData))

I think the code would read nicer if this were phrased positively, like this:
if (!ephemeralMeasurement.isSameSiteOrCrossSiteTriggeringEvent(...))
    return;